Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate encore #4737

Merged
merged 4 commits into from
Oct 19, 2024
Merged

Conversation

fiona-naughton
Copy link
Contributor

@fiona-naughton fiona-naughton commented Oct 18, 2024

Add deprecation messages/warnings for encore referencing the MDAKit mdaencore, per #4274

(The code itself is left for now, but could be replaced (prior to deprecation in 3.0) with the MDAKit later, as for hole2/waterdynamics/psa)

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4737.org.readthedocs.build/en/4737/

@pep8speaks
Copy link

pep8speaks commented Oct 18, 2024

Hello @fiona-naughton! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 36:46: W291 trailing whitespace

Line 35:46: W291 trailing whitespace

Line 36:46: W291 trailing whitespace

Line 35:46: W291 trailing whitespace

Line 38:46: W291 trailing whitespace

Line 35:46: W291 trailing whitespace

Line 36:46: W291 trailing whitespace

Line 35:46: W291 trailing whitespace

Line 33:46: W291 trailing whitespace

Comment last updated at 2024-10-18 15:57:40 UTC

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.27%. Comparing base (48e9e01) to head (669f6b6).
Report is 2 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (48e9e01) and HEAD (669f6b6). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (48e9e01) HEAD (669f6b6)
10 5
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4737      +/-   ##
===========================================
- Coverage    93.60%   86.27%   -7.33%     
===========================================
  Files          173      185      +12     
  Lines        21464    22533    +1069     
  Branches      2993     2993              
===========================================
- Hits         20091    19440     -651     
- Misses         929     2664    +1735     
+ Partials       444      429      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The distopia-related failures need to be fixed elsewhere (#4739 or PR #4734 ).

@orbeckst
Copy link
Member

orbeckst commented Oct 19, 2024

I'd like to have merged develop into this branch but GH did not provide a convenient button to do so. Because I am too lazy to do this locally and because I know that "it will work"™ now that PR #4740 has been merged I am going to merge as is.

EDIT: I'll wait with merging in case anyone else wants to review. @fiona-naughton please merge when you think it's ready and got enough scrutiny.

@orbeckst orbeckst self-assigned this Oct 19, 2024
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@IAlibay IAlibay merged commit 05876f2 into MDAnalysis:develop Oct 19, 2024
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants