-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate encore #4737
Deprecate encore #4737
Conversation
Hello @fiona-naughton! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-10-18 15:57:40 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4737 +/- ##
===========================================
- Coverage 93.60% 86.27% -7.33%
===========================================
Files 173 185 +12
Lines 21464 22533 +1069
Branches 2993 2993
===========================================
- Hits 20091 19440 -651
- Misses 929 2664 +1735
+ Partials 444 429 -15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have merged develop into this branch but GH did not provide a convenient button to do so. EDIT: I'll wait with merging in case anyone else wants to review. @fiona-naughton please merge when you think it's ready and got enough scrutiny. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks!
Add deprecation messages/warnings for encore referencing the MDAKit mdaencore, per #4274
(The code itself is left for now, but could be replaced (prior to deprecation in 3.0) with the MDAKit later, as for hole2/waterdynamics/psa)
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4737.org.readthedocs.build/en/4737/