-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Macaulay2 1.24.11 #3535
Conversation
a57ae51
to
093d263
Compare
Do we have a specific cut off time for creating the release tag? Maybe midnight? |
093d263
to
9906c05
Compare
My tentative plan was to create the tag in the morning (EST) on Friday so that there would be some built packages and documentation later in the day for an announcement. But that may be wishful thinking! |
baef57f
to
88a9f1f
Compare
I've accounted for most of the user-facing changes since the last release in the changelog, with the exception of a few things I'm not as familiar with (complexes, basis, promotion, pseudocode). I've tagged folks in the various PR's for help with these entries. Suggestions for improvement would be much appreciated! |
8656f9c
to
2bca074
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file necessary in git?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently, it's supposed to be: https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package is essentially a glorified word list and file alone is bigger than it. Don't users just insert a couple of files in their HTML?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I was hesitant to add it but was blindly following the documentation. You've convinced me :) I'll remove it soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
2bca074
to
854288b
Compare
Should match existing keywords for other packages
The code is now available as an unexported method in Macaulay2Doc
According to the npm documentation, it should be commited.
854288b
to
c9ea7fa
Compare
Oops sorry that was by accident, although I guess it is ready? |
Beginning work on the next release, planned for next Friday, Nov. 1. I'll rebase this onto
development
as new PR's are accepted.TODO:
RealRoots
-- see #3539)