Added more logging and some code refactor #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martamoraguesteamcmp
approved these changes
Sep 11, 2017
| */ | ||
| public function delete($path) | ||
| private function ensureWeCanWriteDestFile($newpath, $overwrite) |
There was a problem hiding this comment.
we have exactly the same check in src/Cmp/Storage/Adapter/FileSystemAdapter.php
maybe in future common checks between those two classes we can create a common class for check it, and avoid duplicate it.
There was a problem hiding this comment.
I had some doubts about this because it's only one function, but yes, may be is a good idea prepare a trait to afford this duplicate function and future duplicate checks if any.
martamoraguesteamcmp
approved these changes
Sep 11, 2017
| * @param \Exception $e | ||
| */ | ||
| private function logAdapterException($adapter, $e) | ||
| private function logAdapterException(AdapterInterface $adapter, $e) |
| * | ||
| * @throws InvalidStorageAdapterException | ||
| */ | ||
| public function __construct(array $config = [], $bucket = '', $pathPrefix = '') | ||
| public function __construct(array $config = [], $bucket = '', $pathPrefix = '', $options = []) |
There was a problem hiding this comment.
Add array or [] to $option declaration.
| $e = new FileExistsException($newpath); | ||
| $this->logger->log( | ||
| LogLevel::ERROR, | ||
| 'Adapter "'.$this->getName().'" fails. Des file {path} already exists.', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.