-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I made the same mistake again making this PR. #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RVC-Tweaks into pr-optimization
This reverts commit 9b521a3.
for preprocessing Co-Authored-By: kalomaze <66376113+kalomaze@users.noreply.github.com>
Optimize various parts of inference/training + requirement fixes
Ensure compatibility across platforms using os path join
filepaths now work for everything
fixes for all operating systems + lazyimporting
He merged wrong thing to fix the issue I think.
commented out onnx import that wasn't used (was there for debugging.)
kalomaze
changed the title
Revert changes temporarily to solve issues (round 2)
I made the same mistake again making this PR.
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the same mistake again making this PR.