Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slack): invite specific Slack user groups for P1 incidents #110

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

jennafauconnier
Copy link
Collaborator

@jennafauconnier jennafauconnier commented Oct 14, 2024

feat(slack): invite specific Slack user groups for P1 incidents 

Description

Need to add a case when an incident is P1, we have to invite automatically a specific groups of user

Changes Made

  • Add tag field for UserGroup model
  • Make a migration to apply this field
  • Add a new receiver to add specific group when an incident is P1
  • Reorganize the back office presentation of a user groups to be more ux/ui friendly
  • Add a comment into Group model to be more clear. (linked comment for docs)

How to Test

Create a user group with you and others people, create an P1 incident, and check if all users of this groups are invited to this incident.

Checklist

  • I have tested my changes
  • I have updated the documentation (if needed)

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 62.85%. Comparing base (86e516c) to head (6c7c979).

Files with missing lines Patch % Lines
src/firefighter/slack/signals/get_users.py 33.33% 8 Missing ⚠️
src/firefighter/incidents/models/incident.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   62.82%   62.85%   +0.02%     
==========================================
  Files         215      215              
  Lines        9572     9587      +15     
  Branches     1286     1289       +3     
==========================================
+ Hits         6014     6026      +12     
- Misses       3349     3352       +3     
  Partials      209      209              
Flag Coverage Δ
unittests 62.85% <52.63%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GabDug GabDug changed the title Get invitation from Slack for users groups if it's a P1 feat(slack): invite specific Slack user groups for P1 incidents Oct 15, 2024
@GabDug GabDug added the enhancement New feature or request label Oct 16, 2024
@GabDug GabDug merged commit 84cb015 into main Oct 16, 2024
7 checks passed
@GabDug GabDug deleted the feature/critical-incident-responders branch October 16, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants