Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adopt Loggia logger utility #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: adopt Loggia logger utility #84

wants to merge 2 commits into from

Conversation

GabDug
Copy link
Collaborator

@GabDug GabDug commented Jul 11, 2024

Summary

Remove our custom logger configuration, for both production and development environments, to use loggia.

Some of our documentation regarding telemetry has been updated to point to loggia's docs, and tests for our formatters has been removed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.65%. Comparing base (60a7836) to head (bfd780c).

Files with missing lines Patch % Lines
...fighter/firefighter/settings/components/logging.py 87.09% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   62.83%   62.65%   -0.18%     
==========================================
  Files         215      213       -2     
  Lines        9587     9499      -88     
  Branches     1289     1270      -19     
==========================================
- Hits         6024     5952      -72     
+ Misses       3354     3343      -11     
+ Partials      209      204       -5     
Flag Coverage Δ
unittests 62.65% <87.09%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GabDug GabDug changed the title Adopt Loggia logger utility feat: adopt Loggia logger utility Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants