Fix excess execution of fetch #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coordinates that are out of bounds Fix malformed layer- element in index.html Add test TemplatedMapMLTileLayer.test.js. Closes Maps4HTML#936
prushforth
force-pushed
the
empty-fetch-fix
branch
2 times, most recently
from
c424a9e
to
e8b0895
Compare
from the rest of the tests, to see if they will deflake this way
|
Flaky tests popupTabNavigation.test.js and layerContextMenuKeyboard.test.js - both deal with activeElement and focus and routinely fail on github actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix excess execution of fetch on invalid url returned from tile coordinates that are out of bounds.
Needs a test for before/after behaviour.
Closes #936