Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply pre-commit to all files and ignore chart/ #2552

Closed
wants to merge 2 commits into from

Conversation

wslulciuc
Copy link
Member

This PR applies pre-commit to all files and ignores chart/. We will hold off merging this PR until #2520 is merge to avoid merge conflicts.

Signed-off-by: wslulciuc <willy@datakin.com>
@boring-cyborg boring-cyborg bot added api API layer changes docs labels Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #2552 (8709667) into main (55b55bf) will not change coverage.
The diff coverage is n/a.

❗ Current head 8709667 differs from pull request most recent head ca56502. Consider uploading reports for the commit ca56502 to get more accurate results

@@            Coverage Diff            @@
##               main    #2552   +/-   ##
=========================================
  Coverage     83.26%   83.26%           
  Complexity     1286     1286           
=========================================
  Files           243      243           
  Lines          5934     5934           
  Branches        279      279           
=========================================
  Hits           4941     4941           
  Misses          846      846           
  Partials        147      147           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@julienledem julienledem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…m:MarquezProject/marquez into apply-precommit-on-all-files
@wslulciuc wslulciuc enabled auto-merge (squash) August 9, 2023 23:25
@wslulciuc wslulciuc closed this Aug 9, 2023
auto-merge was automatically disabled August 9, 2023 23:59

Pull request was closed

@wslulciuc wslulciuc deleted the apply-precommit-on-all-files branch August 9, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API layer changes docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants