Chart: Dont use hardcoed postgres image for initcontainer #2579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The marquez deployment has a Postgresql wait-for-db init container with a hardcoded image. Due to this the
global.imageRegistry
value is not used for the "wait-for-db" init container. This creates problems for users that has to use private registries.Closes: #ISSUE-NUMBER
Solution
I have added a template in
chart/templates/helpers.tpl
for the postgres image that returns the value from the postgres chart, or theglobal.imageRegistry
input value . The template is then included in thechart/templates/marquez/deployment.yaml
"wait-for-db" initContainer.One-line summary:
Use the same postgresql image value for postgres and "wait-for-db" initcontainer.
Checklist
CHANGELOG.md
(Depending on the change, this may not be necessary)..sql
database schema migration according to Flyway's naming convention (if relevant)