Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2848 & 2468 - Connection error while connecting to postgres from local #2957

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

schandir
Copy link
Contributor

@schandir schandir commented Oct 29, 2024

Problem

This is a fix for the issue #2848 (comment) and #2468

In local, when we bring up the docker container, it complains on the postgres connetion as config is not defaulted to the local postgres

Closes: #2848 & 2468

Solution

Update dev yaml to default local host as postgres connection

Note: All database schema changes require discussion. Please link the issue for context.

One-line summary:

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit feb6671
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6720e3941161c70008130938

Signed-off-by: unknown <nchandir@win.redhat.com>
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree with the change, but also not sure what might be impacted by switching to using localhost (meaning, in terms of docs out in the wild). I don't see this as a major issue though as setting POSTGRES_HOST should be standard practice when running via docker compose. I'll fix the failing migrate-db CI job as follow up.

@wslulciuc wslulciuc merged commit cfb9602 into MarquezProject:main Oct 30, 2024
13 of 14 checks passed
Copy link

boring-cyborg bot commented Oct 30, 2024

Great job! Congrats on your first merged pull request in the Marquez project!

@wslulciuc
Copy link
Member

@schandir as promised, follow up fix for CI job migrate-db #2959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection error while using PostgreSQL and Marquez.
2 participants