Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using
if my_fsm
, it will fallback on__len__
which will raise anOverflowError
in case there are an infinite many strings that match the FSM.We can just check if the FSM is empty. This is "equivalent" with the current implementation in the sense that for FSMs that accept a finite number of strings, the
bool
will be the same for both versions, but by adding a__bool__
we will also returnTrue
if an infinite amount of strings are accepted, and it is less computationally expensive.