Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist/tools: cppcheck fixes static errors & local running #382

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CW-75
Copy link
Collaborator

@CW-75 CW-75 commented Mar 22, 2023

Contribution description

This contribution adds support to run cppcheck locally, when you run the static-test, you'll see the warnings and cppcheck errors. Note: The cppcheck is configured to only process the code folders as firmware, examples, tests, wifi-subsys and boards, it's took as reference these folders which could have cpp and c files.

Testing procedure

Run locally static-tests

make static-test

Issues/PRs references

Fixes #379

@github-actions github-actions bot added Area: tools Area: wifi-subsys It is related to some subsystem labels Mar 22, 2023
@CW-75 CW-75 added this to the 0.23.06-rc2 milestone Mar 22, 2023
@luisan00
Copy link
Contributor

My question here is , how this new changes can affect to the workflow.
i mean, yes you can check all code base locally but in first instance the workflow should be able to check the files changed in the PR.

@luisan00
Copy link
Contributor

Anyway the latest commit in this PR is ok for me, this should fix the recurrent workflow error described in #379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: wifi-subsys It is related to some subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static-test: cppcheck sub-test raises error
2 participants