Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds CUSTOM_TEXT block + guide to create custom blocks #1505

Merged
merged 11 commits into from
Jan 20, 2023

Conversation

dan13ram
Copy link
Member

@dan13ram dan13ram commented Jan 18, 2023

Overview

What features/fixes does this PR include?

  • Fixes existing bugs/issues with the blocks
  • Adds a custom block CUSTOM_TEXT to the list of available blocks in dashboard / player profile / guild profile.
    • This block takes a custom title and markdown content to create a custom text block
  • This PR also adds a guide which can be followed to create similar custom blocks. This guide can also be found at https://hackmd.io/@dan13ram/HJklSISio

Please provide the GitHub issue number

Works upon #264

Implementation

See the new guide for steps used in this PR.

@github-actions github-actions bot temporarily deployed to Test-PR-1505 January 18, 2023 18:58 Destroyed
@dan13ram dan13ram added frontend Front end related issues / features ready-for-review Add this label to your PR when its ready for review labels Jan 18, 2023
Copy link
Contributor

@alalonde alalonde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This definitely opens up a lot of customization options.

Implementation looks pretty straightforward.

packages/utils/package.json Show resolved Hide resolved
return '';
}
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea refactoring this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Front end related issues / features ready-for-review Add this label to your PR when its ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants