-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds CUSTOM_TEXT
block + guide to create custom blocks
#1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan13ram
requested review from
dysbulic,
alalonde,
vidvidvid and
peth-yursick
January 18, 2023 18:58
dan13ram
added
frontend
Front end related issues / features
ready-for-review
Add this label to your PR when its ready for review
labels
Jan 18, 2023
alalonde
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This definitely opens up a lot of customization options.
Implementation looks pretty straightforward.
return ''; | ||
} | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea refactoring this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
frontend
Front end related issues / features
ready-for-review
Add this label to your PR when its ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What features/fixes does this PR include?
CUSTOM_TEXT
to the list of available blocks in dashboard / player profile / guild profile.Please provide the GitHub issue number
Works upon #264
Implementation
See the new guide for steps used in this PR.