Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make onboarding animations faster - READY FOR REVIEW #1578

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

Seroxdesign
Copy link
Contributor

Overview

What features/fixes does this PR include?

https://www.notion.so/meta-game/Landing-Page-CTA-769b61b11fd4413e95784fd12a6c0e79?pvs=4
https://www.notion.so/meta-game/Speed-up-text-in-onboarding-game-by-2x-7c2cfdb7fdea491ba13d05c99df2fe72?pvs=4

Please provide the GitHub issue number

Closes #

Follow up Improvement Ideas

  • please list any improvement/ideas

Implementation

Describe technical (nontrivial / non-obvious) parts of your code

Side effects

Assets

[Include screenshots/videos if it makes reviewing easier.]

@github-actions github-actions bot temporarily deployed to Test-PR-1578 July 18, 2023 11:02 Destroyed
@Seroxdesign Seroxdesign changed the title make onboarding animations faster make onboarding animations faster - rotating langine page CTA Jul 21, 2023
@Seroxdesign Seroxdesign changed the title make onboarding animations faster - rotating langine page CTA make onboarding animations faster Jul 24, 2023
@Seroxdesign Seroxdesign marked this pull request as ready for review July 24, 2023 12:20
@Seroxdesign
Copy link
Contributor Author

@dysbulic @alalonde ready for review.

@github-actions github-actions bot temporarily deployed to Test-PR-1578 July 24, 2023 12:20 Destroyed
@Seroxdesign Seroxdesign changed the title make onboarding animations faster make onboarding animations faster - READY FOR REVIEW Jul 25, 2023
Copy link
Member

@dysbulic dysbulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. The text is tiny on desktop, but that's outside the scope of this PR.

@dysbulic dysbulic added the ready-for-review Add this label to your PR when its ready for review label Jul 26, 2023
@dysbulic dysbulic merged commit 470aacb into develop Jul 26, 2023
19 checks passed
@dysbulic dysbulic deleted the sero/landing-page-cta/text-speed branch July 26, 2023 11:55
@github-actions
Copy link

Successfully undeployed the Preview of this Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Add this label to your PR when its ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants