Switch Quest Chains from ethers to Viem for Contract Access
#1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Innkeeping
reviewed
Jul 9, 2024
Innkeeping
reviewed
Jul 12, 2024
There was a problem hiding this comment.
Do you need the comma before the parentheses on line 54 for Hasura Admin?
There was a problem hiding this comment.
Lines will frequently include a trailing comma so that later when a line is added after it, you don't have to add a comma in that edit.
Otherwise, git will show both lines as changed even though the one that just got a comma isn't meaningfully different.
Innkeeping
reviewed
Jul 12, 2024
dysbulic
added
codebase
Innkeeping
reviewed
Aug 13, 2024
|
Successfully undeployed the Preview of this Pull Request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What features/fixes does this PR include?
Replaces the Quest Chains SDK
contractcode generated by TypeChain with Viem'sgetContract.Follow-Up Improvement Ideas
A Viem client masquerading as an
ethersprovider is still used in several places. Fully transitioning would likely not be too difficult.This is part of the process of transitioning
TheGameback toethersv6so we can use the Ethereum Attestation Service.Also, this is part of migrating the wallet management infrastructure to WalletConnect’s (Wallet|App)Kit.
Implementation
Updates bunches of libraries including the GraphQL generation, ESLint, Ceramic, &
yarnfrom 1.19 to 4.3. Theyarnupdate required quite a bit of finagling with the building & deployment processes.It switches local paths from using the
pathsdirective of TypeScript to theimportssection ofpackage.json.I'm creating a Viem
WalletClientfromwindow.ethereumwithout any additional sign-in. That may be problematic, but all that should get overhauled when integrating AppKit.