-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: INFRA-2087 auto generated issues for mobile and extension repositories #4763
base: main
Are you sure you want to change the base?
Conversation
8e95e76
to
dc8c828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on mapping each controller to an array of team labels, rather than just one? Many of them have multiple code owners. Choosing just one for the label seems a bit arbitrary.
workflow_call: | ||
secrets: | ||
GH_TOKEN: | ||
description: Github token with access to mobile and extention repositories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds more specifics on the required permissions, and fixes a typo:
description: Github token with access to mobile and extention repositories | |
description: GitHub token with permission to create issues in both mobile and extension repositories |
fi | ||
fi | ||
done | ||
shell: bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Add trailing newline
shell: bash | |
shell: bash | |
permissions: | ||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Read permissions are the default, I would not expect this to be required
permissions: | |
contents: read |
.github/workflows/main.yml
Outdated
permissions: | ||
contents: read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default, not required
permissions: | |
contents: read |
Explanation
CI pipeline for auto generated issues when major release of any package occurs. New issues will be created in metamask-extension and metamask-mobile repositories.
References
Changelog
None