CI: INFRA-2087 auto generated issues for mobile and extension repositories #4763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrabenda
commented
Oct 4, 2024
rrabenda
commented
Oct 4, 2024
rrabenda
commented
Oct 4, 2024
rrabenda
force-pushed
the
feat/INFRA-2087-auto-generate-issues
branch
from
8e95e76
to
dc8c828
Compare
rrabenda
commented
Oct 4, 2024
Gudahtt
requested changes
Oct 4, 2024
rrabenda
commented
Oct 10, 2024
Gudahtt
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Thoughts on mapping each controller to an array of team labels, rather than just one? Many of them have multiple code owners. Choosing just one for the label seems a bit arbitrary.
Gudahtt
reviewed
Oct 11, 2024
| workflow_call: | ||
| secrets: | ||
| GH_TOKEN: | ||
| description: Github token with access to mobile and extention repositories |
There was a problem hiding this comment.
This adds more specifics on the required permissions, and fixes a typo:
Suggested change
| description: Github token with access to mobile and extention repositories | |
| description: GitHub token with permission to create issues in both mobile and extension repositories |
Gudahtt
reviewed
Oct 11, 2024
| fi | ||
| fi | ||
| done | ||
| shell: bash |
There was a problem hiding this comment.
Nit: Add trailing newline
Suggested change
| shell: bash | |
| shell: bash | |
Gudahtt
reviewed
Oct 11, 2024
Comment on lines
12
to
13
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
Nit: Read permissions are the default, I would not expect this to be required
Suggested change
| permissions: | |
| contents: read |
Gudahtt
reviewed
Oct 11, 2024
.github/workflows/main.yml
Outdated
Comment on lines
55
to
56
| permissions: | ||
| contents: read |
There was a problem hiding this comment.
Default, not required
Suggested change
| permissions: | |
| contents: read |
makemesteaks
previously approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
CI pipeline for auto generated issues when major release of any package occurs. New issues will be created in metamask-extension and metamask-mobile repositories.
References
Changelog
None