[composable-controller] perf: Optimize expensive reduce operations, fix metadata instantiation #4968
+116
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eating new tmp object every iteration
…non-V2 controllers
…leController state and metadata fields
MajorLift
added
team-wallet-framework
team-tiger
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
…messenger events allowlists
…ller name object keys
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Expensive operations during
ComposableControllerinstantiation contribute to downstream performance issues in our client apps' initialization times. Optimizing these operations may be especially impactful sinceComposableControllertakes large inputs consisting of all of the controllers used by a given client.Explanation
reduceoperations that create temporary objects on each iteration and replace with implementations that re-use their output objects.ComposableControllerto accept an object instead of an array. Now that the mobile Engine creates a controllers object, this saves us an extra operation for converting the object into an array.controllersinput. This is now resolved by using a type object.References
ComposableControllerAPI updates that fix broken functionality metamask-mobile#10441Changelog
@metamask/composable-controllerChanged
ComposableControllerconstructor optioncontrollersand generic type argumentChildControllersare re-defined from an array of controller instances to an object that maps controller names to controller instances.ComposableController'state' field and 'metadata' objects exclude child controllers that do not extend fromBaseControllerorBaseControllerV1.Fixed
ComposableController'metadata' field object now correctly populatesBaseControllerV1controller properties with a metadata object that maps state property names toStateMetadataPropertytype objects.BaseControllerV1controllers were assigned the object{ persist: true, anonymous: true }, and their state properties were overwritten.Checklist