-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add prom client #1087
chore: add prom client #1087
Conversation
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1087 +/- ##
=======================================
Coverage 77.15% 77.15%
=======================================
Files 180 180
Lines 4260 4260
Branches 1050 1050
=======================================
Hits 3287 3287
Misses 973 973 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, just one comment that we may want to rename the read to something more specific.
@SocketSecurity ignore npm/prom-client@15.1.3 |
Quality Gate passedIssues Measures |
@SocketSecurity ignore npm/prom-client@15.1.3 |
Explanation
The current state uses a custom metrics extraction function that manually calculates and formats metrics for total connected clients and total rooms. This approach is limited in scope and requires manual maintenance to add or modify metrics.
The solution introduces the use of the Prometheus client library ('prom-client') to handle metrics collection and formatting. This change offers several advantages:
The changes include:
References
Checklist