Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup sdk dependencies #1088

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat: cleanup sdk dependencies #1088

merged 1 commit into from
Oct 22, 2024

Conversation

abretonc7s
Copy link
Collaborator

Explanation

Some dependencies have incorrectly been moved out of devDependencies.

  • rollup-plugin-visualizer
  • @types/uuid
  • @types/dom-screen-wake-lock

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@abretonc7s abretonc7s requested a review from a team as a code owner October 22, 2024 01:32
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.15%. Comparing base (26cef79) to head (a11cc2e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   77.15%   77.15%           
=======================================
  Files         180      180           
  Lines        4260     4260           
  Branches     1050     1050           
=======================================
  Hits         3287     3287           
  Misses        973      973           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Oct 22, 2024

Copy link
Contributor

@elefantel elefantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s merged commit f062473 into main Oct 22, 2024
36 checks passed
@abretonc7s abretonc7s deleted the sdkdeps branch October 22, 2024 06:12
@abretonc7s abretonc7s mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants