Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove the alert of 'SDK Connection has been terminated' #1095

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

omridan159
Copy link
Contributor

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@omridan159 omridan159 self-assigned this Oct 25, 2024
@omridan159 omridan159 requested a review from a team as a code owner October 25, 2024 08:39
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.16%. Comparing base (8dacf3c) to head (7f7888c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1095      +/-   ##
==========================================
- Coverage   77.27%   77.16%   -0.12%     
==========================================
  Files         180      180              
  Lines        4260     4256       -4     
  Branches     1050     1048       -2     
==========================================
- Hits         3292     3284       -8     
- Misses        968      972       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

} else {
console.info(`SDK Connection has been terminated`);
}
console.info(`SDK Connection has been terminated`);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the console as well, this should be event based. And we should move the logic of handling the disconnection inside the dapps. So for example devnext should listen for disconnect and display "You have been disconnected" modal. We can add the same thing to all examples

Copy link

sonarcloud bot commented Oct 25, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants