-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder categories in the directory #462
base: main
Are you sure you want to change the base?
Conversation
Commit |
|
||
// According to the type definition, `navigate` returns a promise, but in | ||
// practice it does not. | ||
// eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
navigate('/explore', { replace: true }); | ||
navigate('/explore', { replace: true, state: { isFromCategory: true } }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow why this is necessary. We can change the ordering by dispatching setOrder
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explore page should always be on latest ordering, how would I know if the explore page was rendered by it being navigated to via the category page or not.
Closes #2964