Apply suggestions from code review

Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
MetaMask · Feb 16, 2024 · 2703e49 · 2703e49
1 parent 4aaff2f
commit 2703e49
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 7 deletions.
diff --git a/packages/examples/packages/dialogs/CHANGELOG.md b/packages/examples/packages/dialogs/CHANGELOG.md
@@ -8,12 +8,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [2.2.0]
 ### Added
-- Add a link to confirmation dialog in dialog example snap ([#2112](https://github.com/MetaMask/snaps/pull/2112))
+- Add a link to confirmation dialog ([#2112](https://github.com/MetaMask/snaps/pull/2112))
 
 ### Changed
 - Remove snap icon ([#2189](https://github.com/MetaMask/snaps/pull/2189))
 
-
 ## [2.1.0]
 ### Changed
 - Use `@metamask/snaps-sdk` package ([#1930](https://github.com/MetaMask/snaps/pull/1930),

diff --git a/packages/snaps-cli/CHANGELOG.md b/packages/snaps-cli/CHANGELOG.md
@@ -9,9 +9,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [5.1.0]
 ### Changed
 - Optimize CLI Webpack configuration ([#2175](https://github.com/MetaMask/snaps/pull/2175))
-  - This should allow Snap bundles to be much smaller than in the past.
+  - This can reduce the size of Snaps in certain cases.
 - Show Webpack compilation warnings in CLI ([#2186](https://github.com/MetaMask/snaps/pull/2186), [#2192](https://github.com/MetaMask/snaps/pull/2192))
-- Add a warning when no icon is found and when icon is not 1:1 ([#2185](https://github.com/MetaMask/snaps/pull/2185))
+- Add a warning when no icon is found and when icon is not square ([#2185](https://github.com/MetaMask/snaps/pull/2185))
 
 ## [5.0.0]
 ### Changed

diff --git a/packages/snaps-sdk/CHANGELOG.md b/packages/snaps-sdk/CHANGELOG.md
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [2.1.0]
 ### Changed
 - Improve support for Snap errors without a message ([#2176](https://github.com/MetaMask/snaps/pull/2176))
+  - You can now add data to an error without having to specify a message. For example:
+    ```ts
+    throw new MethodNotFoundError({ method: 'some method name' });
+    ```
 - Strip empty `data` from Snap errors ([#2179](https://github.com/MetaMask/snaps/pull/2179))
 
 ## [2.0.0]

diff --git a/packages/snaps-utils/CHANGELOG.md b/packages/snaps-utils/CHANGELOG.md
@@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [6.1.0]
 ### Added
-- Add a manifest warning when no icon is found and when icon is not 1:1 ([#2185](https://github.com/MetaMask/snaps/pull/2185))
+- Add a manifest warning when no icon is found and when icon is not square ([#2185](https://github.com/MetaMask/snaps/pull/2185))
 
 ## [6.0.0]
 ### Added

diff --git a/packages/snaps-webpack-plugin/CHANGELOG.md b/packages/snaps-webpack-plugin/CHANGELOG.md
@@ -8,10 +8,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [3.2.0]
 ### Added
-- Add a manifest warning when no icon is found and when icon is not 1:1 ([#2185](https://github.com/MetaMask/snaps/pull/2185))
+- Add a manifest warning when no icon is found and when icon is not square ([#2185](https://github.com/MetaMask/snaps/pull/2185))
 
 ### Changed
-- Change warning output format ([#2186](https://github.com/MetaMask/snaps/pull/2186))
+- Update warning messages ([#2186](https://github.com/MetaMask/snaps/pull/2186))
 - Bump several MetaMask dependencies ([#2054](https://github.com/MetaMask/snaps/pull/2054), [#2100](https://github.com/MetaMask/snaps/pull/2100), [#2105](https://github.com/MetaMask/snaps/pull/2105), [#2173](https://github.com/MetaMask/snaps/pull/2173))
 
 ## [3.1.1]