Address breaking changes

MetaMask · Oct 25, 2024 · b9177f9 · b9177f9
1 parent 4811770
commit b9177f9
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 4 deletions.
diff --git a/packages/snaps-execution-environments/src/common/BaseSnapExecutor.test.browser.ts b/packages/snaps-execution-environments/src/common/BaseSnapExecutor.test.browser.ts
@@ -1971,7 +1971,7 @@ describe('BaseSnapExecutor', () => {
       error: {
         code: -32603,
         message:
-          'Received non-JSON-serializable value: Expected the value to satisfy a union of `literal | boolean | finite number | string | array | record`, but received: 0.',
+          'Received non-JSON-serializable value: Expected a value of type `JSON`, but received: `0`.',
         stack: expect.any(String),
       },
     });

diff --git a/packages/snaps-execution-environments/src/common/BaseSnapExecutor.ts b/packages/snaps-execution-environments/src/common/BaseSnapExecutor.ts
@@ -192,6 +192,7 @@ export class BaseSnapExecutor {
     const serializedError = serializeError(error, {
       fallbackError: unhandledError,
       shouldIncludeStack: false,
+      shouldPreserveMessage: false,
     });
 
     const errorData = getErrorData(serializedError);
@@ -280,6 +281,7 @@ export class BaseSnapExecutor {
       await this.#respond(id, {
         error: serializeError(rpcError, {
           fallbackError,
+          shouldPreserveMessage: false,
         }),
       });
     }

diff --git a/packages/snaps-rpc-methods/src/permitted/getFile.test.ts b/packages/snaps-rpc-methods/src/permitted/getFile.test.ts
@@ -152,7 +152,7 @@ describe('snap_getFile', () => {
 
       expect(response.error).toStrictEqual({
         code: -32603,
-        message: 'Internal JSON-RPC error.',
+        message: 'foo bar',
         data: {
           cause: {
             message: 'foo bar',

diff --git a/packages/snaps-rpc-methods/src/permitted/middleware.test.ts b/packages/snaps-rpc-methods/src/permitted/middleware.test.ts
@@ -82,7 +82,7 @@ describe('createSnapsMethodMiddleware', () => {
         data: {
           cause: expect.objectContaining({ message: 'foo' }),
         },
-        message: 'Internal JSON-RPC error.',
+        message: 'foo',
       },
     });
   });

diff --git a/packages/snaps-rpc-methods/src/permitted/requestSnaps.test.ts b/packages/snaps-rpc-methods/src/permitted/requestSnaps.test.ts
@@ -441,7 +441,7 @@ describe('implementation', () => {
       error: {
         code: -32603,
         data: { cause: expect.objectContaining({ message: 'error' }) },
-        message: 'Internal JSON-RPC error.',
+        message: 'error',
       },
       id: 1,
       jsonrpc: '2.0',