Add a manifest warning when no icon is found and when icon is not 1:1 #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/fast-xml-parser@4.2.5 |
FrederikBolding
changed the title
FrederikBolding
force-pushed
the
fb/add-warning-when-icon-not-specified
branch
from
22f1822
to
8da1716
Compare
|
@metamaskbot update-pr |
FrederikBolding
force-pushed
the
fb/add-warning-when-icon-not-specified
branch
from
43667aa
to
71fee67
Compare
|
@metamaskbot update-pr |
FrederikBolding
force-pushed
the
fb/add-warning-when-icon-not-specified
branch
from
a99e9e5
to
5dea6e5
Compare
|
@metamaskbot update-pr |
Mrtenz
requested changes
Feb 16, 2024
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
FrederikBolding
force-pushed
the
fb/add-warning-when-icon-not-specified
branch
from
1534114
to
d1bd116
Compare
|
@metamaskbot update-pr |
Mrtenz
previously approved these changes
Feb 16, 2024
Mrtenz
approved these changes
Feb 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
==========================================
+ Coverage 96.55% 96.57% +0.01%
==========================================
Files 331 332 +1
Lines 7482 7525 +43
Branches 1152 1161 +9
==========================================
+ Hits 7224 7267 +43
Misses 258 258 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a manifest warning when no icon is found and when the icon is not 1:1. Adding new utility functions for parsing SVGs and getting the dimensions of a parsed SVG.
This PR also replaces
is-svgwith our own SVG parsing using the same underlying library thatis-svgwas using before. We now exclusively rely onfast-xml-parser.This PR also slightly changes the Webpack plugin to make the warning output less verbose.
Closes #1736