Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Webpack plugins add compilation warnings instead of logging #2192

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Feb 16, 2024

Instead of logging to the console directly, the SnapsBundleWarningsPlugin now adds a compilation warning to Webpack. The warning will be shown after compilation by the SnapsStatsPlugin. I've also updated the formatting of text, so text is formatted based on the size of the terminal.

@Mrtenz Mrtenz requested a review from a team as a code owner February 16, 2024 13:29
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a783ef6) 96.57% compared to head (8b5a48d) 96.57%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2192   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         332      332           
  Lines        7525     7542   +17     
  Branches     1161     1165    +4     
=======================================
+ Hits         7267     7284   +17     
  Misses        258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding
Copy link
Member

🧙‍♂️

@Mrtenz Mrtenz merged commit 1a512f2 into main Feb 16, 2024
150 checks passed
@Mrtenz Mrtenz deleted the mrtenz/plugin-warnings branch February 16, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants