-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: @metamask/rpc-errors@^6.3.1->^7.0.0 #2817
Draft
legobeat
wants to merge
8
commits into
MetaMask:main
Choose a base branch
from
legobeat:deps-rpc-errors-7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/eth-json-rpc-middleware@14.0.2, npm/@metamask/providers@17.2.1 |
legobeat
force-pushed
the
deps-rpc-errors-7
branch
from
October 17, 2024 03:25
cf032c4
to
ecce9e8
Compare
This was referenced Oct 17, 2024
legobeat
force-pushed
the
deps-rpc-errors-7
branch
from
October 18, 2024 11:22
dfee8bf
to
1c12ef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@metamask/rpc-errors
from^6.3.1
to^7.0.0
shouldPreserveMessage
tofalse
for all invocations ofserializeError
Open question
Currently
snaps-rpc-methods
tests fail because some errors now have the new (old) behavior of not wrapping error messages.Haven't figured out if there is something else at play as well/instead but looks like at least
@metamask/json-rpc-engine
callsserializeError
with default arguments which are not currently overridable (though that dependency is still on v6 so TBD)If the above is correct, which of these options are preferred?
JsonRpcEngine
to allow overridingserializeError
optionssnaps-rpc-methods
to accomodate to new defaultsRelated
@metamask/snaps-sdk
?