Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch NFT by id instead of generating a watch NFT button for each token id #247

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

seaona
Copy link
Contributor

@seaona seaona commented Jul 25, 2023

Context

After the Watch NFT function has been added, we can see how button elements are created whenever we mint NFTs. I.e. minting 30 NFTs would correspond to create 30 watch NFT buttons.
This can be inefficient in terms of UI.

With this PR, we can watch the NFT by its id (instead of generating the long list of buttons).

Before

If you minted 30 NFTs, you would get 30 buttons, for watching each individual asset.

Screenshot from 2023-07-25 11-17-01

After

You can Watch the NFT by inputting its id, instead of getting a long list of buttons (corresponding to each id)

Screenshot from 2023-07-25 11-33-04

@seaona seaona requested a review from a team as a code owner July 25, 2023 09:32
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seaona seaona merged commit e57f1cc into main Aug 17, 2023
3 checks passed
@seaona seaona deleted the nft-by-id branch August 17, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants