Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and cleanup interface to DataTransformation #54

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Refactor and cleanup interface to DataTransformation #54

merged 4 commits into from
Sep 2, 2024

Conversation

dnerini
Copy link
Member

@dnerini dnerini commented Sep 2, 2024 •
edited
Loading

Refine #43. Most notably, remove input variables and let the DataTransformer handle all that logic.

@dnerini dnerini requested a review from louisPoulain September 2, 2024 06:30
@dnerini dnerini self-assigned this Sep 2, 2024
louisPoulain
louisPoulain approved these changes Sep 2, 2024
View reviewed changes
Copy link
Collaborator

@louisPoulain louisPoulain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me. The only thing I'm afraid of is the compatibility with already registered models that I have (since there's a new value in the identity dictionnary) but I will need to check if some of my models did use the identity.

mlpp_lib/normalizers.py Show resolved Hide resolved
@dnerini dnerini merged commit c653c51 into main Sep 2, 2024
2 checks passed
@dnerini dnerini deleted the refactor-normalizers branch September 2, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisPoulain louisPoulain louisPoulain approved these changes

Assignees

@dnerini dnerini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnerini @louisPoulain