Make some tests more lenient #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tput appears to be optional for this plugin, so the tests should not fail if we cannot find tput.
In some exotic packaging environments like Nixpkgs, we enforce heavy amounts of sandboxing; we do not include git by default in that sandbox. Additionally, in said exotic packaging environments, we should not always assume we are in a Git repository. The Nixpkgs GitHub fetcher functions by downloading a tarball, not the whole Git directory, so the test fails.
tomodachi94
commented
Dec 10, 2024
| @@ -6,6 +6,9 @@ | |||
| } | |||
|
|
|||
| @test 'ysu version exported' { | |||
| (( $+commands[git] )) || skip "git not found" | |||
There was a problem hiding this comment.
I elected to use pure Zsh when checking if a command is present to avoid a dependency on which.
This increase performance slightly, and also avoids a dependency on which.
| @@ -38,6 +38,8 @@ | |||
| } | |||
|
|
|||
| @test 'ysu - _write_ysu_buffer invalid' { | |||
| (( $+commands[tput] )) || skip "tput not found" | |||
There was a problem hiding this comment.
I'm not sure about this one. I would want the CI/CD pipeline to fail if tput is not installed rather than fail silently.
There was a problem hiding this comment.
That's understandable. I can drop the tests: skip tests requiring tput if not present commit if you prefer. I added this because YSU gracefully handles a missing tput.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of my work to run unit tests in the Nixpkgs
zsh-you-should-usepackage, so that potential breakages are caught early.