Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marge all valid pull reqeusts and add some new badges #80

Closed
wants to merge 37 commits into from
Closed

Marge all valid pull reqeusts and add some new badges #80

wants to merge 37 commits into from

Conversation

0x61nas
Copy link

@0x61nas 0x61nas commented Sep 3, 2022

And other small improvements

0x61nas and others added 30 commits August 31, 2022 16:40
@0x61nas
Copy link
Author

0x61nas commented Sep 3, 2022

@klaasnicolaas
Copy link

Why do you put other people's work in your own PR? After all, these are still open for review (which will probably never happen). This way is really a no go...

@0x61nas
Copy link
Author

0x61nas commented Sep 3, 2022

@klaasnicolaas Because the badges.fig file cannot be merged like normal code files, but it is combined as a single block so if it merges any pull request will cause conflicts in the rest, so it must be merged manually, I took the trouble and I merged all the valid pull requests manually

@0x61nas
Copy link
Author

0x61nas commented Sep 3, 2022

@klaasnicolaas thanks for thumbs down, Most likely it will not even be merged or reviwed, because it is clear that there has been no activity from the owner in this repository for a year or more so rest assured 🥲 , I will create and maintain my version, and this is the main reason why I merge pull requests because it has been open for a while and has not been merged

@klaasnicolaas
Copy link

You could also have asked first before merging everything 😉 Think you can understand that this action does not seem particularly desirable at first, for those who have previously worked on their own PR. That the figma file can cause merge conflicts is a problem that could have been foreseen from the beginning of this repository. Good luck maintaining your own fork 👍🏻

@0x61nas 0x61nas closed this by deleting the head repository Sep 3, 2022
@0x61nas 0x61nas reopened this Sep 3, 2022
@0x61nas 0x61nas closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Badge for Github Blazor
2 participants