Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaled_dot_product_attention fallback to controlmodel_ipadapter.py for PyTorch v1 compatibility #2707

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ochen1
Copy link

@ochen1 ochen1 commented Mar 29, 2024

This is important because PyTorch v2 cannot be used with my RX 5600 XT due to a regression in ROCm.

This should not break things for those using PyTorch v2. A code review and testing would be appreciated.

@ochen1
Copy link
Author

ochen1 commented Mar 30, 2024

There appears to be a merge conflict. I am planning to resolve the conflict soon.

@ochen1
Copy link
Author

ochen1 commented Mar 31, 2024

Merge conflict has been resolved. Ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant