Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix args initializer #2938

Merged
merged 1 commit into from
May 28, 2024
Merged

Fix args initializer #2938

merged 1 commit into from
May 28, 2024

Conversation

huchenlei
Copy link
Collaborator

@huchenlei huchenlei commented May 28, 2024

Using = [] in pydantic BaseModel will make all instances share the same default object, which is dangerous.

@huchenlei huchenlei merged commit c91dbe5 into Mikubill:main May 28, 2024
2 checks passed
@huchenlei huchenlei deleted the fix_init branch May 28, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant