Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.19.x] Rewrite Getting Started #490

Merged

Conversation

ChampionAsh5357
Copy link
Contributor

@ChampionAsh5357 ChampionAsh5357 commented Mar 29, 2023

Rewrites the getting started section to be more friendly to new modders or those who do not have the relevant experience in minecraft modding. Adds explicit mentions against those who do not know the languages or tools they need to use.

Making this a draft since maty told me to work on FG5 first, so...yeah. Here's just keeping things open on how far I've gotten.

Part of #486

Supersedes #484

  • index.md
  • contributing.md
  • gettingstarted
    • index.md
    • structuring.md
    • versioning.md

@ChampionAsh5357 ChampionAsh5357 added Page Improvement Improves an existing page 1.19 For Minecraft 1.19.x labels Mar 29, 2023
@ChampionAsh5357 ChampionAsh5357 self-assigned this Mar 29, 2023
@ChampionAsh5357
Copy link
Contributor Author

Ok, this should be ready for review. I've restructured it to be more like the wiki without any of the extra redundancies.

@ChampionAsh5357 ChampionAsh5357 marked this pull request as ready for review May 7, 2023 19:31
docs/gettingstarted/index.md Outdated Show resolved Hide resolved
docs/gettingstarted/index.md Show resolved Hide resolved
docs/gettingstarted/modfiles.md Outdated Show resolved Hide resolved
docs/gettingstarted/structuring.md Outdated Show resolved Hide resolved
docs/gettingstarted/index.md Outdated Show resolved Hide resolved
docs/gettingstarted/index.md Show resolved Hide resolved
docs/gettingstarted/modfiles.md Outdated Show resolved Hide resolved
docs/gettingstarted/modfiles.md Outdated Show resolved Hide resolved
docs/gettingstarted/modfiles.md Outdated Show resolved Hide resolved
docs/gettingstarted/structuring.md Outdated Show resolved Hide resolved
docs/gettingstarted/structuring.md Outdated Show resolved Hide resolved
docs/gettingstarted/modfiles.md Outdated Show resolved Hide resolved
docs/gettingstarted/structuring.md Outdated Show resolved Hide resolved
docs/gettingstarted/structuring.md Outdated Show resolved Hide resolved
docs/concepts/resources.md Outdated Show resolved Hide resolved
docs/contributing.md Outdated Show resolved Hide resolved
docs/gettingstarted/index.md Outdated Show resolved Hide resolved
docs/gettingstarted/index.md Show resolved Hide resolved
docs/gettingstarted/versioning.md Outdated Show resolved Hide resolved
ChampionAsh5357 and others added 2 commits May 10, 2023 10:57
Co-authored-by: matyrobbrt <65940752+Matyrobbrt@users.noreply.github.com>
- Mention what is the top-level package in example
- Add IntelliJ as supported
- Add back link to ComparableVersion
docs/gettingstarted/index.md Outdated Show resolved Hide resolved
docs/gettingstarted/index.md Outdated Show resolved Hide resolved
docs/gettingstarted/index.md Outdated Show resolved Hide resolved
docs/gettingstarted/index.md Outdated Show resolved Hide resolved
docs/gettingstarted/index.md Outdated Show resolved Hide resolved
docs/gettingstarted/structuring.md Outdated Show resolved Hide resolved
docs/gettingstarted/structuring.md Outdated Show resolved Hide resolved
docs/gettingstarted/structuring.md Outdated Show resolved Hide resolved
docs/gettingstarted/structuring.md Outdated Show resolved Hide resolved
docs/gettingstarted/versioning.md Show resolved Hide resolved
Co-authored-by: sciwhiz12 <sciwhiz12@gmail.com>
@Icicles0
Copy link

I think this should just get merged already

- Fix admonition inlining
- Change `gradlew build` -> `gradlew`
- Mention base.archivesName as alternative to archivesBaseName
- Mention 0.0NONE for impl version
- Fix module explanation text
- Standardize 'Maven'
@ChampionAsh5357 ChampionAsh5357 requested a review from sciwhiz12 May 10, 2023 19:57
@ChampionAsh5357
Copy link
Contributor Author

I think this should just get merged already

It only makes sense to merge something once we consider it to be accurate. Especially since we are rewriting this to be more explanatory and user friendly to new modders.

docs/gettingstarted/index.md Outdated Show resolved Hide resolved
@sciwhiz12 sciwhiz12 merged commit e6f4b2f into MinecraftForge:1.19.x May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.19 For Minecraft 1.19.x Page Improvement Improves an existing page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants