-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.19.x] Rewrite Getting Started #490
Merged
sciwhiz12
merged 19 commits into
MinecraftForge:1.19.x
from
ChampionAsh5357:rewrites/202303/getting-started
May 10, 2023
Merged
[1.19.x] Rewrite Getting Started #490
sciwhiz12
merged 19 commits into
MinecraftForge:1.19.x
from
ChampionAsh5357:rewrites/202303/getting-started
May 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChampionAsh5357
added
Page Improvement
Improves an existing page
1.19
For Minecraft 1.19.x
labels
Mar 29, 2023
Ok, this should be ready for review. I've restructured it to be more like the wiki without any of the extra redundancies. |
Matyrobbrt
suggested changes
May 7, 2023
PaintNinja
reviewed
May 8, 2023
Matyrobbrt
suggested changes
May 8, 2023
- modid in-code - mod id in text
Co-authored-by: matyrobbrt <65940752+Matyrobbrt@users.noreply.github.com>
Matyrobbrt
suggested changes
May 10, 2023
Co-authored-by: matyrobbrt <65940752+Matyrobbrt@users.noreply.github.com>
- Mention what is the top-level package in example - Add IntelliJ as supported - Add back link to ComparableVersion
Matyrobbrt
approved these changes
May 10, 2023
sciwhiz12
suggested changes
May 10, 2023
Co-authored-by: sciwhiz12 <sciwhiz12@gmail.com>
I think this should just get merged already |
- Fix admonition inlining - Change `gradlew build` -> `gradlew` - Mention base.archivesName as alternative to archivesBaseName - Mention 0.0NONE for impl version - Fix module explanation text - Standardize 'Maven'
It only makes sense to merge something once we consider it to be accurate. Especially since we are rewriting this to be more explanatory and user friendly to new modders. |
sciwhiz12
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the getting started section to be more friendly to new modders or those who do not have the relevant experience in minecraft modding. Adds explicit mentions against those who do not know the languages or tools they need to use.
Making this a draft since maty told me to work on FG5 first, so...yeah. Here's just keeping things open on how far I've gotten.
Part of #486
Supersedes #484