Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clothing update #507

Draft
wants to merge 55 commits into
base: main
Choose a base branch
from
Draft

Conversation

BenCheung0422
Copy link
Member

@BenCheung0422 BenCheung0422 commented Jun 21, 2023

This depends on #445
This changes the way of dyeing clothes to suit the changes to the color system.
Also, a cauldron is added for dyeing clothes, but it can also be reserved the further plans on implementing brewing using cauldron.
Changes:

  • Default player shirt color is changed from #333300 to #EFEFEF.
  • Wide range of player shirt color is supported, theoretically full range of 24-bit RGB values.
  • A cauldron furniture is added.
    • Only water and empty buckets can be used for filling water into and taking (undyed) water from a cauldron respectively.
    • Each time adding dyes to a filled cauldron, the color changes with the calculation of the Minecraft leather dyeing algorithm.
    • A cauldron filled with undyed water can remove dyes from clothes and with dyed water can dye the clothes without losing the dyed water when a player interacting a clothing item on it.
  • Old clothing items are replaced by 1 item Clothes.
    • Old recipes of clothes are replaced by 1 replacement recipe: cloth * 5 -> clothes * 1.
    • Old items are converted into a new clothing item with the old RGB value.
  • White tint coloring algorithm has made changes:
    • For every color value having same R, G and B values, tints are applied.
    • Textures associated with white tint (sheep entity, potion item) have been adjusted by adding 1 R and 1 B to pixels having same R, G and B values.

@Makkkkus Makkkkus added the Low priority Something that should be fixed in the long-term. label Jun 22, 2023
BenCheung0422 and others added 23 commits June 23, 2023 19:55
Totally 19 types of flowers replacing original 2 flowers
This will be redone later.
# Conflicts:
#	src/client/java/minicraft/item/ClothingItem.java
#	src/client/java/minicraft/item/Recipe.java
#	src/client/java/minicraft/item/Recipes.java
#	src/client/java/minicraft/item/StackableItem.java
#	src/client/java/minicraft/level/tile/FlowerTile.java
#	src/client/java/minicraft/level/tile/Tiles.java
#	src/client/java/minicraft/saveload/Load.java
#	src/client/java/minicraft/saveload/Save.java
It is no longer used.
# Conflicts:
#	src/client/java/minicraft/level/tile/WoolTile.java
Flower item tile model unmatched
Flower loading old worlds not resolved, fallen back to daisy by default
Change `* 16` to `<< 4`
@BenCheung0422 BenCheung0422 added On hold Issue has been put on hold for various reasons. F-Update Issue related to update(s) of feature, changing particular functionalities and systems. F-Expansion Issue related to expanding particular existing features or systems. labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-Expansion Issue related to expanding particular existing features or systems. F-Update Issue related to update(s) of feature, changing particular functionalities and systems. Low priority Something that should be fixed in the long-term. On hold Issue has been put on hold for various reasons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants