Update controller code for key detection and add setting for controller enablement #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/client/java/minicraft/item/FishingRodItem.java # src/client/java/minicraft/item/SummonItem.java # src/client/java/minicraft/screen/AchievementsDisplay.java
Due to the change to in-app notification improvements
|
New status information for both controller availability and input method, added with the help of the addition of the status bar from #587. Minicraft.Plus.2024-02-10.01-12-22.mp4 |
# Conflicts: # src/client/java/minicraft/core/io/InputHandler.java
# Conflicts: # src/client/java/minicraft/core/Renderer.java # src/client/java/minicraft/screen/TutorialDisplayHandler.java
# Conflicts: # src/client/java/minicraft/entity/furniture/DeathChest.java
BenCheung0422
added
the
UX/QoL
BenCheung0422
added
Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #587
A setting for controller enablement is added, with a default value of disabled. It detects controller configurations now if and only if it is enabled. It now automatically searches for another controller plugged (and selects the first result) when the using one is no longer plugged. It is currently impossible to provide an ability to specify a controller connected because of the limitations of the currently using library.
The code for key status is also updated, and it is now using the similar mechanism to keyboard key input detections.
Controller status is added with the help of the addition of #587, 2 status, controller availability and input method, as shown in the demo below.