Fix direct-grab sliders getting stuck at maximum value #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgoodnow-ML
requested review from
marlenaklein-msft,
AMollis,
shaynie and
a team
as code owners
…er is configured for grab interaction (IsTouchable = false)
dgoodnow-ML
force-pushed
the
944-fix-grabbable-sliders
branch
from
8bc1f68 to
da0cd07
Compare
|
I added the tests and test prefabs to the uxcore project, although they are based on the canvas slider components in the UX components package. Let me know if I should relocate the tests and supporting prefabs somewhere more appropriate. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@AMollis, please review for tests and test locations |
AMollis
requested changes
Oct 23, 2024
| public class SliderTests : BaseRuntimeInputTests | ||
| { | ||
| private const string TouchSliderPrefabPath = | ||
| "Packages/org.mixedrealitytoolkit.uxcore/Tests/Runtime/Prefabs/TouchSliderTest.prefab"; |
There was a problem hiding this comment.
The UXCore package is not meant to have prefabs in it. And I would hate to have to maintain two sets of prefabs (one in UXCore and one in UXComponents)
So please move this unit tests to UXComponents, and add use the official prefabs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes direct-grab sliders getting stuck at the maximum value when the slider value range is not 0-1.
Remap
StartSliderValueto normalized range before applying normalized interactor movement and clamping to 0-1 rangeAdditionally fixes issue with non-grab sliders snapping to 0 or maximum value when slider minimum value is less than 0 (not covered in issue description, found during testing)
Use minimum slider value instead of
0as startingStartSliderValuefor snapped slider manipulationsresolves #944