Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Augment SerializableDictionary to allow temporary duplicates in Editor #961

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[main] Augment SerializableDictionary to allow temporary duplicates in Editor #961

wants to merge 1 commit into from

Conversation

whebertML
Copy link
Contributor

@whebertML whebertML commented Dec 12, 2024 •
edited
Loading

Fixes #958

  • Also fixes an issue with the "Init Controllers" type lookup within
    InteractionModeManager.InitializeControllers() to find XRBaseControllers
    instead of XRControllers, since the legacy MRTK controllers derive from
    XRBaseControllers, and the GUI button previously wasn't finding any
    controller to initialize in the Inspector.

@whebertML whebertML self-assigned this Dec 12, 2024
@whebertML whebertML changed the title Augment SerializableDictionary to allow temporary duplicates in Editor [main] Augment SerializableDictionary to allow temporary duplicates in Editor Dec 12, 2024
@ghazen-ml
Copy link
Contributor

Were you able to tests locally for this change? See #960

ghazen-ml

This comment was marked as duplicate.

Sign in to view

ghazen-ml
ghazen-ml requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@ghazen-ml ghazen-ml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to tests locally for this change? See #960

@whebertML
Copy link
Contributor Author

@ghazen-ml Haven't done the full battery of local tests yet, will do.

@whebertML
Augment SerializableDictionary to allow temporary duplicates in Editor
274fee9 
* Also fixes an issue with the "Init Controllers" type lookup within
  InteractionModeManager.InitializeControllers() to find XRBaseControllers
  instead of XRControllers, since the legacy MRTK controllers derive from
  XRBaseControllers, and the GUI button previously wasn't finding any
  controller to initialize in the Inspector.
@whebertML whebertML mentioned this pull request Dec 18, 2024
Open
@whebertML
Copy link
Contributor Author

Test results for branch main: All passed (217 out of 219 passed, 2 are ignored):

Editor Test Runner:
image

PowerShell:
image

@whebertML whebertML requested a review from ghazen-ml December 19, 2024 19:48
@whebertML
Copy link
Contributor Author

@ghazen-ml Ran tests, all checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marlenaklein-msft marlenaklein-msft Awaiting requested review from marlenaklein-msft marlenaklein-msft is a code owner

@AMollis AMollis Awaiting requested review from AMollis AMollis is a code owner

@shaynie shaynie Awaiting requested review from shaynie shaynie is a code owner

@ghazen-ml ghazen-ml Awaiting requested review from ghazen-ml

Requested changes must be addressed to merge this pull request.

Assignees

@whebertML whebertML

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Serialization Error When Using XRI 3 + Unity 6
2 participants
@whebertML @ghazen-ml