[feature/XRI3] Augment SerializableDictionary to allow temporary duplicates in Editor #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whebertML
requested review from
marlenaklein-msft,
AMollis,
shaynie and
a team
as code owners
* Also fixes an issue with the "Init Controllers" type lookup within InteractionModeManager.InitializeControllers() to find XRBaseControllers instead of XRControllers, since the legacy MRTK controllers derive from XRBaseControllers, and the GUI button previously wasn't finding any controller to initialize in the Inspector.
whebertML
force-pushed
the
issue958_XRI3
branch
from
1534ed9 to
f0ecec1
Compare
|
Test results for branch feature/XRI3: All passed (256 out of 258 passed, 2 are ignored): Editor Test Runner: PowerShell: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #958
(in feature/XRI3 branch)
InteractionModeManager.InitializeControllers() to find XRBaseControllers
instead of XRControllers, since the legacy MRTK controllers derive from
XRBaseControllers, and the GUI button previously wasn't finding any
controller to initialize in the Inspector.