Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue when inserting a point along a non-manifold edge with 2 singular extremities #287

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Algiane
Copy link
Member

@Algiane Algiane commented Oct 28, 2024

Change the return value when BezierNom is called along a non-manifold edge with 2 singular extremities.

If we return 1. The point is inserted along the nom edge but its normals have not been computed (so they can be NaN).

An example of error can be found when running the ls-DisIn-cubegeom-metric-fields-5 test case of ParMmg.

…edge with 2 singular extremities.

If we return 1. The point is inserted along the nom edge but its normals have not been computed (so they can be NaN).
@Algiane Algiane added kind: bug error or fault part: mmg3d mmg3d specific part: mesh adaptation mesh adaptation mode specificity part: surface model specific to surface model priority: high linked to blocking behaviour or to a close deadline labels Oct 28, 2024
@Algiane Algiane self-assigned this Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.45%. Comparing base (af80663) to head (1e303f8).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #287   +/-   ##
========================================
  Coverage    50.45%   50.45%           
========================================
  Files          177      177           
  Lines        47239    47239           
  Branches     10272    10272           
========================================
+ Hits         23834    23836    +2     
+ Misses       15673    15671    -2     
  Partials      7732     7732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@corentin-prigent
Copy link
Contributor

Thanks !

@corentin-prigent corentin-prigent merged commit 4d8232c into develop Oct 29, 2024
49 checks passed
@corentin-prigent corentin-prigent deleted the feature/BezierNom-retval branch October 29, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug error or fault part: mesh adaptation mesh adaptation mode specificity part: mmg3d mmg3d specific part: surface model specific to surface model priority: high linked to blocking behaviour or to a close deadline
Projects
Development

Successfully merging this pull request may close these issues.

2 participants