-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure minimum version of cmake is 3.10 #291
base: develop
Are you sure you want to change the base?
Ensure minimum version of cmake is 3.10 #291
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #291 +/- ##
========================================
Coverage 50.45% 50.45%
========================================
Files 177 177
Lines 47239 47239
Branches 10272 10272
========================================
Hits 23836 23836
Misses 15671 15671
Partials 7732 7732 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pourquoi a-t-on besoin de cette version?
Les dernières versions de cmake considèrent comme obsolètes les versions de cmake antérieures à 3.10, d'où la modification. |
Why should you care? |
@prj- Do you need < 3.10 cmake ? I think the rationale is to avoid ever having an issue raised because of old cmakes. |
No, I don’t need it, but I’m not sure I understand the rationale for increasing the minimum version just because CMake is marking old releases as obsolete. |
No description provided.