Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure minimum version of cmake is 3.10 #291

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

corentin-prigent
Copy link
Contributor

No description provided.

@corentin-prigent corentin-prigent added part: cmake cmake part priority: low linked to weak improvements or to a distant deadline labels Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.45%. Comparing base (4d8232c) to head (fce3dce).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #291   +/-   ##
========================================
  Coverage    50.45%   50.45%           
========================================
  Files          177      177           
  Lines        47239    47239           
  Branches     10272    10272           
========================================
  Hits         23836    23836           
  Misses       15671    15671           
  Partials      7732     7732           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taupalosaurus taupalosaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi a-t-on besoin de cette version?

@corentin-prigent corentin-prigent self-assigned this Dec 6, 2024
@corentin-prigent
Copy link
Contributor Author

Les dernières versions de cmake considèrent comme obsolètes les versions de cmake antérieures à 3.10, d'où la modification.

@prj-
Copy link
Contributor

prj- commented Dec 10, 2024

Why should you care?

@taupalosaurus
Copy link
Contributor

@prj- Do you need < 3.10 cmake ? I think the rationale is to avoid ever having an issue raised because of old cmakes.

@prj-
Copy link
Contributor

prj- commented Dec 10, 2024

No, I don’t need it, but I’m not sure I understand the rationale for increasing the minimum version just because CMake is marking old releases as obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: cmake cmake part priority: low linked to weak improvements or to a distant deadline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants