-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/implement user and friends apis #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
element를 #기준으로 split해서 맨 앞 요소를 rendering
- Implemented `UserDetailView` for user information retrieval and update. - Implemented `FriendDetailView`: - Created `FriendRequestSerializer` for managing friend requests. - Updated Swagger documentation to correctly define request bodies and responses for friend APIs.
…plement-user-and-friends-apis
- Usage: python manage.py populatedb
….com/MomHelpMe/Transcendence into feat/implement-user-and-friends-apis
mounted를 observable로 포함시키고 그에따른 수정
fetch 범위 밖에 있던 filter 함수를 범위 안으로 옮겨서 해결
….com/MomHelpMe/Transcendence into feat/implement-user-and-friends-apis
- 기능에 따라 모든 요청의 port 번호를 80으로 변경 - docker-compose.yml로 실행 시 80 포트가 아닌 5173 포트로 리다이렉트되는 문제가 있기 때문에 OAuth 변경이 필요함
….com/MomHelpMe/Transcendence into feat/implement-user-and-friends-apis
github-actions
bot
requested review from
cozy-hn,
jaehejun,
minseok128 and
seungwonme
August 17, 2024 12:24
minseok128
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
곧 제 브랜치에 머지하면서 꼼꼼히 리뷰하겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 구현 사항
리뷰어 참고 사항