Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front/feat/common error page #32

Merged
merged 3 commits into from
Sep 1, 2024
Merged

Front/feat/common error page #32

merged 3 commits into from
Sep 1, 2024

Conversation

seonjo1
Copy link
Contributor

@seonjo1 seonjo1 commented Sep 1, 2024

주요 구현 사항

  • 404 에러 페이지를 위한 javascript 파일들의 이름을 변경했습니다.
  • 404 에러 페이지의 css 를 수정했습니다. (뭐가 달라졌게???)
스크린샷 2024-09-01 오후 5 52 29
  • 공통적으로 쓸 에러 페이지를 만들었습니다.
    • 우선 중복 로그인시 에러페이지가 나오도록 설정하였습니다.
    • 나중에 추가로 필요시 changeUrl("/error")를 사용하면 됩니당
스크린샷 2024-09-01 오후 5 52 46
  • 에러 페이지들에 다국어 지원을 적용했습니다.

minseok128
minseok128 approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@minseok128 minseok128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

내 에러 페이지가 드디어 생겼군요

@minseok128 minseok128 merged commit 0a97442 into main Sep 1, 2024
2 checks passed
@seonjo1 seonjo1 deleted the front/feat/common-error-page branch September 2, 2024 00:45
@seonjo1
Copy link
Contributor Author

seonjo1 commented Sep 2, 2024

디스 이즈 포 유!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minseok128 minseok128 minseok128 approved these changes

@cozy-hn cozy-hn Awaiting requested review from cozy-hn

@jaehejun jaehejun Awaiting requested review from jaehejun

@seungwonme seungwonme Awaiting requested review from seungwonme

Assignees

@seonjo1 seonjo1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seonjo1 @minseok128