Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create squiggle mutation #172

Merged

Conversation

priyadarshini-silpa
Copy link
Contributor

@priyadarshini-silpa priyadarshini-silpa commented Jan 4, 2023

Solved or Linked Issues #155

Reference any and all issues solved and related to this pull request here. Mention if there are none.

Description and Changes

Please describe your pull request with all changes made.

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a work/topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the development (left side). Also you should start your branch off default branch and follow the branch naming guidelines.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation and mentioned the related issues (if appropriate)
  • I have added the appropriate labels, requested a review from a repository manager and assigned myself to this pull request.

Post merge checklist

Copy link
Member

@120EE0692 120EE0692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rutajdash code seems fine to me, permission check to be added.

@rutajdash rutajdash requested a review from 120EE0692 January 31, 2023 13:59
@rutajdash rutajdash enabled auto-merge (squash) January 31, 2023 13:59
@rutajdash rutajdash disabled auto-merge February 6, 2023 15:10
@rutajdash rutajdash merged commit bb9b909 into Monday-Morning:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants