Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter and lint existing files #107

Merged
merged 9 commits into from
Nov 8, 2024
Merged

Add linter and lint existing files #107

merged 9 commits into from
Nov 8, 2024

Conversation

ryanleung
Copy link
Collaborator

@ryanleung ryanleung commented Nov 8, 2024 •
edited
Loading

This PR does the following:

  • Adds linting pipeline
  • Adds per commit linting
  • lints existing files
  • fixes up some security checks that arose with the linting changes

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 8, 2024
View reviewed changes
requirements.txt
# Linting dependencies
pre-commit==3.5.0
flake8==7.0.0
black==24.2.0

Check warning

Code scanning / Trivy

psf/black: ReDoS via the lines_with_leading_tabs_expanded() function in strings.py file Medium

Package: black
Installed Version: 24.2.0
Vulnerability CVE-2024-21503
Severity: MEDIUM
Fixed Version: 24.3.0
Link: CVE-2024-21503
@LachsBagel LachsBagel changed the base branch from main to 0.2.1 November 8, 2024 19:53
@LachsBagel LachsBagel merged commit d62ee3c into 0.2.1 Nov 8, 2024
@ryanleung ryanleung deleted the ryanleung-linter branch November 8, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanleung @LachsBagel