Remove localized from partner html template and moved to get_context #12978
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n.mozilla.org into TP1-104-remove-localized-partner Merge
…/MozillaFoundation/foundation.mozilla.org into TP1-104-remove-localized-partner Merge
danielfmiranda
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Hi @dlopezvsr!
Thank you for taking on this work—everything is looking great and working as expected! 👍
I just have one minor suggestion before we merge, and then it should be good to go.
| @@ -11,7 +11,7 @@ <h2 class="tw-h3-heading">{{ page.partner_heading }}</h2> | |||
| {{ page.partner_intro_text }} | |||
| </p> | |||
| {% endif %} | |||
| <a href="{{ page.partner_page.localized.url }}" class="text-white tw-cta-link font-weight-bold" id="partner-cta"> | |||
| <a href="{{ localized_partner_page.url }}" class="text-white tw-cta-link font-weight-bold" id="partner-cta"> | |||
There was a problem hiding this comment.
Suggested change
| <a href="{{ localized_partner_page.url }}" class="text-white tw-cta-link font-weight-bold" id="partner-cta"> | |
| {% if localized_partner_page %} | |
| <a href="{{ localized_partner_page.url }}" class="text-white tw-cta-link font-weight-bold" id="partner-cta"> | |
| {% endif %} |
Hi @dlopezvsr, while I was testing this out, I found that even if the "partner_page" was not set, this <a> element was still rendering. However, since there was no localized_partner_page to grab a URL from, it was just linking back to localhost:8000.
Can we please wrap this in a {% if %} statement? That way, this button wont render unless the page is set.
Thanks!
Comment on lines
+1016
to
+1017
| if self.partner_page: | ||
| context["localized_partner_page"] = self.partner_page.localized |
There was a problem hiding this comment.
Kudos Looks good to me. Great job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
.localizedattribute frompartner.htmltemplate as part of thelocalizecleanup. This also moves the logic to page'sget_contextfunctioncontext["localized_partner_page"]returning a localized version of the page.Link to sample test page:
Related PRs/issues: #10011
How to test
See images below.
Checklist
Tests
Changes in Models:
Documentation:
Merge Method
💡❗Remember to use squash merge when merging non-feature branches into
main┆Issue is synchronized with this Jira Story