Adapt FastReflection for Paper 1.20.5 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried with Adventure, it works again! |
x9nico
approved these changes
Apr 28, 2024
|
Can confirm this also works on Spigot/Paper 1.20.6 |
|
I tried in Paper 1.20.6 (build 28), it works to :)
|
MrMicky-FR
reviewed
May 1, 2024
MrMicky-FR
approved these changes
May 1, 2024
x9nico
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paper brought the end of the CraftBukkit package relocation. I guess I shouldn't have tested with a modified
FastReflectionclass in my own plugin for #50.TheVERSIONfield is now an empty string on Paper 1.20.5, or on servers that have already previously disabled the relocation. I kept theOBC_PACKAGEstatic field because it ispublic, and some plugins may rely on it.Tested on Paper 1.20.5, Paper 1.20.4 and Spigot 1.8.3, without Adventure.