LazyPartition #21
Merged
LazyPartition #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The previous example was followed by ancestral reconstruction which LazyPartition doesn't support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
LazyPartitionSummary
With this data structure, you can wrap a partition of choice.
The idea is that in some message passing algorithms, there is only a wave of partitions which need to actualize.
For instance, a wave following a root-leaf path, or a depth-first traversal.
In which case, we can be more economical with our memory consumption.
With a worst case memory complexity of O(log(n)), where n is the number of nodes, functionality is provided for:
log_likelihood!felsenstein!sample_down(Further functionality is under development)
Documentation
An example of how to use
LazyPartitionis provided in https://github.com/nossleinad/MolecularEvolution.jl/tree/LazyPartition/docs/src/models.mdUse case
An argument in favour of this PR is that
LazyPartitioncould be integrated in the difFUBAR method with brevity, where it dramatically reduced the memory footprint of larger datasets. MurrellGroup/CodonMolecularEvolution.jl@b09b0c9