Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve #88 & #5 anms exp bld 001 navigation filtering #123

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Resolve #88 & #5 anms exp bld 001 navigation filtering #123

merged 4 commits into from
Aug 26, 2024

Conversation

njbrunner
Copy link
Contributor

Changes:

  • Added URI encoding to support filtering the transcoder log table on input string and URI
  • Added transcoder log id filtering option on the transcoder log table
  • Added an active color to selected page for tables with pagination

Testing Suggestions:

  • Test table pagination
  • Test filtering the transcoder log table on the following values:
    • Transcoder Log ID
    • Input String
    • CBOR
    • URI

@njbrunner njbrunner self-assigned this Aug 21, 2024
@njbrunner njbrunner linked an issue Aug 21, 2024 that may be closed by this pull request
ANMS_EXP_BLD_001 (Navigation) - Filtering #88
Closed
@BrianSipos BrianSipos added this to the ANMS v1.1.0 milestone Aug 21, 2024
BrianSipos
BrianSipos reviewed Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@BrianSipos BrianSipos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source change look good but I'm not able to test the behavior right now

@d-linko
Copy link
Contributor

d-linko commented Aug 21, 2024

every looked good to me but i was having some issues with updating the page size not loading correctly the first time. I uncommented code that was there that set the page number to 1 after updating the page size and that seemed to fix the issue

@njbrunner njbrunner merged commit 28e4e82 into main Aug 26, 2024
4 checks passed
@njbrunner njbrunner deleted the 88-anms_exp_bld_001-navigation-filtering branch August 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianSipos BrianSipos BrianSipos left review comments

@d-linko d-linko d-linko approved these changes

Assignees

@njbrunner njbrunner

Labels
None yet
Projects
ANMS
Status: Done
Milestone
ANMS v1.1.0
Development

Successfully merging this pull request may close these issues.

ANMS_EXP_BLD_001 (Navigation) - Filtering
3 participants
@njbrunner @d-linko @BrianSipos