Skip to content

Commit

Permalink
deprecate AnnotationFilterView, bioportalSearch in LookupModel
Browse files Browse the repository at this point in the history
Issue #1654
  • Loading branch information
robyngit committed Sep 9, 2024
1 parent 386fecd commit 097e445
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions src/js/models/LookupModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ define(["jquery", "jqueryui", "underscore", "backbone"], function (

initialize: function () {},

/** deprecated */
bioportalSearch: function (request, response, localValues, allValues) {
// make sure we have something to lookup
if (!MetacatUI.appModel.get("bioportalAPIKey")) {
Expand Down
8 changes: 5 additions & 3 deletions src/js/views/filters/SemanticFilterView.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ define([
/**
* @class SemanticFilterView
* @classdesc Render a specialized view of a single Filter model using the
* AnnotationFilterView.
* BioontologySelectView. Essentially acts as a connector between the Filter
* model and the Bioontology model. Uses logic from both the FilterView and
* the BioontologySelectView.
* @classcategory Views/Filters
* @augments FilterView
* @screenshot views/filters/SemanticFilterView.png
Expand Down Expand Up @@ -43,8 +45,8 @@ define([
/**
* Render an instance of a Semantic Filter View. Note that this View
* doesn't have a template and instead delegates to the
* AnnotationFilterView which renders a SearchSelectView which renders the
* BioontologySelectView.
* BioontologySelectView which renders a SearchSelectView which renders
* the BioontologySelectView.
* @returns {SemanticFilterView} This instance
* @since 2.22.0
*/
Expand Down
1 change: 1 addition & 0 deletions src/js/views/searchSelect/AnnotationFilterView.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ define(["jquery", "underscore", "backbone", "bioportal"], function (
* @constructor
* @since 2.14.0
* @screenshot views/searchSelect/AnnotationFilterView.png
* @deprecated since 0.0.0
*/
return Backbone.View.extend(
/** @lends AnnotationFilterView.prototype */
Expand Down

0 comments on commit 097e445

Please sign in to comment.