Adding colors to dark theme for #2376 #2377
Conversation
| --portal-grey-5: #80868B; | ||
| --portal-grey-6: #5F6368; | ||
| --portal-grey-7: #3C4043; | ||
| --portal-grey-8: #202124; |
There was a problem hiding this comment.
Hi Ian! This color palette is specific to the light theme so I'd recommend not directly copying over the config from light.css. The issue described in the ticket is about layer category color, which is defined here. I think the fix should be two stepped:
-
Set --portal-col-text-highlight in dark.css to a legible color in the context of dark theme. This variable is used by other components as well (.layer-details__label, .viewfinder-prediction__content) so you'll see a color change at those places. This fix will also only apply to portals that explicitly use the dark theme. Map in the main repo, for example, will still use the fallback color of --map-col-highlight__deprecate.
-
To address the issue for non-theme users, we can replace the fallback color in map-view.css with the same color from # 1.
There was a problem hiding this comment.
Hi @yvonnesjy! Thank you, I appreciate the heads up and the detailed explanation. I just assumed that copying the blues and greys definitions to dark.css and changing the specific variable references would be sufficient to make the dark theme more legible without causing problems elsewhere. I can change to define them directly.
Closes #2376